Closed Cube707 closed 1 year ago
Thank you for a report, I sort of inherited the version from the package cutie
without really having a look. Will fix right away
no hurry, I am don't need this fixed urgently.
I am the maintainer of readchar
and sometimes just look around who uses it and help out with getting problems known I caused 😆
Had a quick look, did you force some update of reachar
? In pyproject.toml
it's capped to ^3.1.0
which would be >=3.1.0, <4.0.0
What do you mean by, force some update? I changed the pyproject.toml
to allow for a v4
install to test if you mean that.
Yes, that is what I meant, sorry for being unclear. Anyway, thank you very much for this report! Now it should be resolved.
And big props for maintaining readchar
, if you could use some help over there I'd be glad to contribute.
I am still wanting to implement a context-handler version of readchar
, which should fix the "keypresses are dropped outside of readchar" issue and finaly enable noneblocking
support.
I that peaks your interest, I will gladly accept a PR. But I will get around to it eventually myself :)
Sounds interesting, I will have a look at the codebase sometime soon.
when runnign a example like this:
raise_on_interrupt = False
does not work as expected. Instead using CTRL+C will still raise a interupt. This is true forreadchar==3.1.0
(the currently pinnt version) and after updating toreadchar==4.2.0
.The relevant reason for this is, that
readchar
changed it's behavior inv4
to raise interrupts by default, not passing CTRL+C to the caller. You can however disable this, if you want to handle it yourself, by changingreadchar.config.INTERRUPT_KEYS
(see here)