petereon / beaupy

A Python library of interactive CLI elements you have been looking for
https://petereon.github.io/beaupy/
MIT License
183 stars 13 forks source link

Switching from readchar.readkey() to click.getchar() #34

Closed petereon closed 1 year ago

petereon commented 1 year ago

Changes:

petereon commented 1 year ago

Keys constants are possibly very off, this might be something to use in testing them: https://pypi.org/project/keyboard/

codecov-commenter commented 1 year ago

Codecov Report

Merging #34 (998b2d1) into master (4e72587) will increase coverage by 0.32%. The diff coverage is 98.78%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   98.10%   98.42%   +0.32%     
==========================================
  Files           3        5       +2     
  Lines         264      318      +54     
  Branches       72       72              
==========================================
+ Hits          259      313      +54     
  Partials        5        5              
Flag Coverage Δ
unittests 98.42% <98.78%> (+0.32%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
beaupy/_beaupy.py 97.68% <97.50%> (+0.13%) :arrow_up:
beaupy/key/_key.py 100.00% <100.00%> (ø)
beaupy/key/_posix_key.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

petereon commented 1 year ago

TODOs:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.1% 95.1% Coverage
0.0% 0.0% Duplication