Closed petereon closed 1 year ago
Should resolve #37 and #38
TODO: manual testing on Windows and Linux
Merging #40 (15bbb21) into master (82ddf6c) will decrease coverage by
0.23%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 98.47% 98.23% -0.24%
==========================================
Files 5 3 -2
Lines 328 284 -44
Branches 77 81 +4
==========================================
- Hits 323 279 -44
Partials 5 5
Flag | Coverage Δ | |
---|---|---|
unittests | 98.23% <100.00%> (-0.24%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
beaupy/_beaupy.py | 97.76% <100.00%> (-0.02%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Kudos, SonarCloud Quality Gate passed!
just FYI, the sourcecode of this new package is functional identical to readchar
, it even uses the same stackoverflow and gist post as reference XD
the use of the regex to check for escape-sequences is a fancy idea though
Yeah, it's fairly similar, I am not saying I haven't peeked into readchar
several times, standing on the shoulders of giants so to say. But maan was it painful to get it to work with both ESC
key and COPY-PASTING - with blocking stdin read it was either-or scenario. Nevertheless, I decided to go with non-blocking and handling nasty cases myself, having to abandon all the dignity in form of performance considerations and software design. But it is what it is :laughing:
Third attempt to get a satisfactory
sys.stdin
handling with the features I am hoping for while trying my absolute best to cause as little mess as I thinkably can.