petereon / beaupy

A Python library of interactive CLI elements you have been looking for
https://petereon.github.io/beaupy/
MIT License
181 stars 13 forks source link

Rewriting for Questo #81

Closed petereon closed 7 months ago

petereon commented 7 months ago

BeauPy suffers from very strong coupling between representation an logic. This vastly impacted my ability to deliver features and further extend this library. This pull request aims to remedy this problem.

This also addresses a number of issues, namely:

codecov-commenter commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4d9b97e) 98.37% compared to head (02eb2ad) 99.27%.

Files Patch % Lines
beaupy/_beaupy.py 99.04% 0 Missing and 1 partial :warning:
beaupy/_internals.py 98.80% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #81 +/- ## ========================================== + Coverage 98.37% 99.27% +0.89% ========================================== Files 3 3 Lines 370 411 +41 Branches 99 101 +2 ========================================== + Hits 364 408 +44 + Misses 1 0 -1 + Partials 5 3 -2 ``` | [Flag](https://app.codecov.io/gh/petereon/beaupy/pull/81/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+V%C3%BDboch) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/petereon/beaupy/pull/81/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+V%C3%BDboch) | `99.27% <98.94%> (+0.89%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+V%C3%BDboch#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information