peterfajdiga / FastDraw

A simple Android launcher with categories
42 stars 6 forks source link

Remove widget min height #35

Closed ljoonal closed 2 months ago

ljoonal commented 2 months ago

Has been annoying me lately that the min widget size is more than what I actually need from it, and just large enough that it makes an extra row of apps cause a scrollbar on my device.

Alternatively to this could configure some smaller min size I guess if there really is some sort of a reason to enforce a min size.

peterfajdiga commented 2 months ago

The minimum height needs to be at least enough to display the widget edit controls (the buttons and the resize handle). If a smaller height is allowed, the resizing behaves a bit weird. I've started working on a solution.

peterfajdiga commented 2 months ago

Can you try https://github.com/peterfajdiga/FastDraw/commit/4732ab968b675368a4461ab96ab6ae96cb8d0c55 ?

ljoonal commented 2 months ago

Still seems like it uses more space than needed just for the handle, but at least now it's small enough that my own issue with the min size is fixed :laughing:

peterfajdiga commented 2 months ago

Can you post a screenshot with the handle and buttons visible?

ljoonal commented 2 months ago

Like said, it's good enough for me 😆 Screenshot_20240716-151503 I didn't investigate as to if it's just padding to make it look nice, or perhaps Android reserving more space for the punch hole camera than it needs to, but IMO there's still a bit of space left at the top, at least visually 😄

peterfajdiga commented 2 months ago

@ljoonal Thanks for the screenshot. This is intentional to make it look balanced when the handle is hidden. There is also a margin around the widget itself for aesthetic purposes.