search

peterfajdiga / karousel

Scrollable tiling Kwin script
GNU General Public License v3.0
287 stars 5 forks source link

Karousel does not respect window rules under wayland. #14

Closed baduhai closed 1 year ago

baduhai commented 1 year ago

Everything is tiled under wayland, even programs you explicitly tell karousel to ignore. This is likely an upstream issue.

peterfajdiga commented 1 year ago

Hi, thanks for the report. One reason it would work on X11, but not on Wayland, is that some windows have a different class name on Wayland, e.g. Dolphin has "dolphin" on X11, but "org.kde.dolphin" on Wayland.

If it doesn't work on X11 either, then it's possible that you have a syntax error somewhere in the window rules JSON. At the moment parsing just silently fails and Karousel ignores the rules in this case. I need to figure out a way to display an alert dialog in this case.

peterfajdiga commented 1 year ago

I've added a notification message that is displayed when the JSON is malformed. If you try the latest release (0.4), do you get this notification?

baduhai commented 1 year ago

So, I don't know what I've changed(I don't think my json was malformed), but it started working now. The only windows that don't respect the rules are windowed widgets now, like the timer. Though I have a feeling that it's because I don't have the correct class name, or because their class name is wonky under wayland.