search

peterfajdiga / kwin4_effect_geometry_change

A KWin animation for windows moved or resized by programs or scripts
GNU General Public License v3.0
43 stars 3 forks source link

Adds config diag and readies for publishing. #1

Closed acristoffers closed 1 year ago

acristoffers commented 1 year ago

Hi there.

Do you plan to publish this? I was looking for something like this in the KDE Store and couldn't find, than found this repository. I added a configuration dialogue to set the animation speed and modified the meta-data files so that it can get published.

peterfajdiga commented 1 year ago

Hi! I do plan to publish this in the KDE Store. Now that I see it may be useful to someone, I'll prioritize it, but it may still take a while before I find some time.

Thank you very much for the pull request, but it includes some changes that I would prefer not to merge. For example, I'd prefer not to change the formatting of the code, as I'd like the style to be consistent with another project that I'm working on.

The animation speed config is a great idea, but I'd prefer to make the dialog consistent with those of the built-in effects (example).

Give me some time and I'll get to it. Do you allow me to copy parts of your pull request if I'll need to?

acristoffers commented 1 year ago

For sure, go ahead :)

peterfajdiga commented 1 year ago

I've added the config and I've published the effect on the KDE Store: https://store.kde.org/p/2026302