search

peterflynn / svg-preview

Brackets extension to live preview SVG files inline as you edit them
46 stars 8 forks source link

Add code hints? #10

Closed thany closed 9 years ago

thany commented 10 years ago

Would it be possible to have this extension also add code hints for SVG files, andpossibly for tags within <svg> within rwgular html?

sprintr commented 10 years ago

@thany Have a look at my extension https://github.com/sprintr/brackets-svg-code-hints

thany commented 10 years ago

Of course there would be an extension for this :)

Is your extension properly context-aware? I.e. it would suggest only attributes applicable to the editing element, and suggest only elements that may exist within the parent one?

sprintr commented 10 years ago

I didn't understand the parent relation. it is context-aware in a sense that it provides attributes of the editing element.

thany commented 10 years ago

Sorry, I mean that it doesn't hint elements in places where they may not appear...

sprintr commented 10 years ago

No, I meant its implementation, eg linearGradient can be inside svg and defs, So it will be a little hard to implement.

peterflynn commented 9 years ago

Closing since code hints for SVG are now a core Brackets feature. They don't have all the fancy context-awareness you suggested, but I think the right place for those improvements would be in Brackets itself rather than here.

thany commented 9 years ago

Well, maybe in Brackets 1.2... But 1.2 has a huge bug that keeps many users from using it.

peterflynn commented 9 years ago

@thany That bug was present in 1.1 also and it didn't stop a few hundred thousand people from updating :-)

At any rate, that doesn't justify building a complete duplicate of that functionality in this extension. If you really want, it'd be far less work to download the Brackets source and run the 1.2 JS code in the 1.0 native shell.