Search: remaining adjustments

[peterfremlin]

• [x] search over tagged categories/countries

There are three links in Zimbabwe/health. But when I search for "zimbabwe health" (in main search bar, without filters) it only gives two, because one of them is from zimbabwe being a tagged country, rather than the principal country.

It would be good if that search returned all three.

• [x] In library link results, the tag to region gives the wrong link

e.g. searching for "Mapping and Recommendations on Disability-Inclusive Education" the library link result is tagged to Africa and the url to /library/regionafrica. I'm not sure why this isn't country-africa - but either way region-africa is the correct url.

If that's a problem on my json side, let me know?

• [x] saved settings don't need cookies, just a "copy saved search line"

Thanks for making it more functional, but I prefer simpler, just a line that says "Copy a link to this search."

• [x] trailing whitespace in library link results

for example the placement of "zimbabwe" in this should be directly after preceeding text

This could well be trailing whitespace from my json, so let me know if needs to be fixed my side

• [x] Pages for Regions should have the same globe by it as countries

eg by Asia, here:

[cathysarisky]

I need some help understanding this: "There are three links in Zimbabwe/health. But when I search for "zimbabwe health" (in main search bar, without filters) it only gives two, because one of them is from zimbabwe being a tagged country, rather than the principal country."

What's a 'tagged country'? Am I missing something from your data structure?

[cathysarisky]

"In library link results, the tag to region gives the wrong link" - thanks. I think I'm handling continents listed as countries wrong in some way. Will investigate.

[cathysarisky]

I need some help understanding this: "There are three links in Zimbabwe/health. But when I search for "zimbabwe health" (in main search bar, without filters) it only gives two, because one of them is from zimbabwe being a tagged country, rather than the principal country."

What's a 'tagged country'? Am I missing something from your data structure?

@peterfremlin , I /think/ I've improved the results when no filters are chosen. I'm still not sure I exactly understand this request, so please take a look. (Database changes are live on site. Display changes are not.)

[cathysarisky]

See above for revision on handling regions. Input/feedback welcome. It feels a little weird to list Africa > Africa, but that's how your database is actually set up, I guess, so...

[peterfremlin]

Most this is looking great however:

• there is a problem on the link some country/region tags in library link results.

e.g. if I search for "Mapping and Recommendations on Disability-Inclusive Education" the library link result is tagged "africa" but clicking that leads to an /undefined/. It should go to country-africa

e.g. if I search for "disabled body ages" then it is "international news" and that should go to country-int

• slight change needed to results text

Currently reads "209 library links, 0 pages, 142 newsletters found.". We've removed the pages category (?) so that is always 0 and should be removed. Newsletters are displayed before library links, so should be "142 newsletters, 209 library links found"

• in the titles of "newsletter results" and "library links results", rename to "Newsletters" and "Library links"

[cathysarisky]

Thanks. I'll get the undefined link corrected.

Second bullet point: I'm sorry, I've lost the context here. Did you decide you didn't want pages shown?

[peterfremlin]

Ah sorry my mistake I'd forgotten about the pages results! Please keep those. But adjust the order of announcement to match the order they are on the page itself

[cathysarisky]

agreed, it's weird that the order doesn't match! So... we like the order the results are displayed in, but the summary at the top should match it? (Or we like the order of the summary, and please adjust the results?)

[peterfremlin]

We like the order results are displayed, change the summary to match