peterfremlin / Disability-Debrief

0 stars 0 forks source link

Tag page template #6

Closed peterfremlin closed 1 year ago

peterfremlin commented 1 year ago

A page template that will list the posts of the primary tag under the page text.

(i.e. so that the tag page can be changed in the editor).

cathysarisky commented 1 year ago

Sure. Can be doe either by matching the page slug to the tag slug, OR by applying the tag to the page. Your choice of options - the second one may be less fiddly, and gives you the option to have two tags show up together.

Do you want the existing styling for a tag page, just with the extra page content (using Dawn's existing styles) at the top, or something else?

Do you want the tag description displayed somewhere? What about the tag name, or will you use the page title?

peterfremlin commented 1 year ago

I think your first question is about way to set it up with routes/etc.

On the styling question, I don't love the existing styling of a tag page, and I don't need tag description/title as essentially I would be making that page content. I think I want a regular page styling that I can totally adjust in the editor, then the posts underneath.

cathysarisky commented 1 year ago

Got it. I was asking if the way the posts at the bottom should look matches something on the site already. :)

cathysarisky commented 1 year ago

Done. See directions about author page setup.

peterfremlin commented 1 year ago

Nice solution.

However the tags could easily have a page named by that by accident, so rather than defaulting to /{slug} can it check the page /tag-{slug} and load from there

cathysarisky commented 1 year ago

Absolutely, no problem.

On Tue, Aug 29, 2023 at 11:40 AM peterfremlin @.***> wrote:

Nice solution.

However the tags could easily have a page named by that by accident, so rather than defaulting to /{slug} can it check the page /tag-{slug} and load from there

— Reply to this email directly, view it on GitHub https://github.com/peterfremlin/Disability-Debrief/issues/6#issuecomment-1697699534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCXDVTJB4M2VKCBNBEEEEDXXYEQLANCNFSM6AAAAAA3C5HCJQ . You are receiving this because you commented.Message ID: @.***>

peterfremlin commented 1 year ago

A visual issue on these pages is a bit of a coordination between the article list and what comes before.

see eg

Screenshot 2023-08-31 at 14 09 16
cathysarisky commented 1 year ago

Title added (in the HBS for both tag and author pages).

It's the same font, but a bit smaller. To my eye, the clash is coming from the difference in margin. Here's a tweak that makes the feed match the content margin:

image What do you think about that? I can make the fonts be the same size, but then the feed section will definitely need to be wider to accommodate larger text.

cathysarisky commented 1 year ago

Have adjusted the tag page to look for tag-something instead of just something as a page slug. Have added a "tag page" custom template that you can assign to these tag pages that'll automatically redirect the user to the correct page, in case they get there on accident.

peterfremlin commented 1 year ago

The reduced margin looks good on the author pages. Not sure if it's in the tag pages yet?

The "articles" title on author/tag pages will be better in the style of h2 in the regular pages, rather than the styling used on home page

peterfremlin commented 1 year ago

The author page template should use the same image style as the narrow feature image template.

cathysarisky commented 1 year ago

adjusted. Tags and authors.

cathysarisky commented 1 year ago

Oops, still looking at the h2 question. Here's the default h2 styling. Is this what you had in mind? image

peterfremlin commented 1 year ago

There is a different styling of the h2 in gh-content. But I think the solution is for me to make the title in the editor, rather than the template, as that will let me adjust things as necessary and change the titles for different pages.

The thing to do is to reduce the spacing between the list of articles and the text of the editor, so it can come with a natural space after an h2 made in the editor.

cathysarisky commented 1 year ago

Doing this for tags now. Do you want the authors page the same way? Or just better match gh-content h2 and keep it hard-coded as "articles"?

cathysarisky commented 1 year ago

Label created at the end of the tag-tagslug page, as an H2. I also added two carriage returns before the h2.

image

peterfremlin commented 1 year ago

Do the same for authors please

cathysarisky commented 1 year ago

completed.