petergridge / Irrigation-V5

Irrigation custom component for Home Assistant
GNU General Public License v3.0
71 stars 12 forks source link

the programm is running every day and is ignoring the configured days #83

Closed AlexanderTurnowsky closed 1 month ago

AlexanderTurnowsky commented 1 month ago

I have the latest version installed [V5.4.20] and HA 2024.8.3. It's configured like you described it in https://github.com/petergridge/Irrigation-V5/blob/main/help/help.md. It was working before the last version and HA 2024.7.4. see screenshot, it says it will run tomorrow but was running today. image In the past i had for sure also the old addon installed with the "scheduler component".

Any suggestion how i can fix this?

myreczek commented 1 month ago

I have 5.4.20 with HA 2024.8.3 and have the same issue. It begun probably after upgrade to 5.4.20.

petergridge commented 1 month ago

Hi, are you using an automation to set the start time? There has been an impact on the latest release where if the start time changes dynamically it can manifest with your problem.

myreczek commented 1 month ago

Hi, are you using an automation to set the start time? There has been an impact on the latest release where if the start time changes dynamically it can manifest with your problem.

No, start time is fixed.

Program 1
  name:Program 1
  start_time:input_datetime.program_1_start
  device_type:generic
  Zone 1
    zone:switch.garden_valve_state
    water:input_number.zone_1_runtime
    water_adjustment:sensor.precipitation_probability
  run_freq:sensor.watering_frequency
  irrigation_on:input_boolean.zavlaha
  interlock:True
  controller_monitor:binary_sensor.springorsummer
Screenshot 2024-09-11 at 13 09 08
petergridge commented 1 month ago

Are you getting any errors in the log? The last run status is 2 weeks ago that looks like something is failing to update if it is running everyday

AlexanderTurnowsky commented 1 month ago

on my side as you see in the screenshot it is updated, but still runs everyday. The time is fixed set to 7:30, like you described in your documentation.

petergridge commented 1 month ago

I can see the 'next run' is correctly set to 2 days, but I would expect the 'last ran' to be <24hrs.

Can you try a numeric frequency 3 or 4 to see if that performs as expected. I am testing the named days now. I typically use every 3 days in my implementation.

myreczek commented 1 month ago

The named days setup forked just fine whole summer.

I tried to change start time to 1:35 PM, days Mon,Fri:

Screenshot 2024-09-11 at 13 36 01

But it started anyway with these warnings:

2024-09-11 13:35:06.022 WARNING (MainThread) [custom_components.irrigationprogram.irrigationzone] Significant latency has been detected, zone switch may not be updating state correctly, unexpected behaviour may occur, switch.garden_valve_state
2024-09-11 13:35:11.037 WARNING (MainThread) [custom_components.irrigationprogram.irrigationzone] Switch has latency exceding 5 seconds, cannot confirm switch.garden_valve_state state is off

Valve switch is working just fine if switched manually. It's a Zigbee switch on Z2M. But why did the irrigation start when it's wednesday today? I try to change setup to N-frequency.

myreczek commented 1 month ago

It runs everytime regardless of the plan.

Screenshot 2024-09-11 at 13 41 09
myreczek commented 1 month ago

Also, I have the same issue as described in #81

AlexanderTurnowsky commented 1 month ago

Also, I have the same issue as described in #81

this is also on my side, maybe this has something to do with it.

petergridge commented 1 month ago

I have identified the issue here, unrelated to #81, a fix applied for another issue introduce this one. I still have a lot of testing before releasing it.

Loic691 commented 1 month ago

Hi @petergridge This is the same for me. We had discussion about this issue in another thread. I done other tests and confirm the programs run everyday even with no change in startime.

petergridge commented 1 month ago

V2024.09.01 is up as a Beta, there has been a lot of change under the covers so please let me know if you experience issues.

Loic691 commented 1 month ago

V2024.09.01 is up as a Beta, there has been a lot of change under the covers so please let me know if you experience issues.

Updated. Waiting next cycle tomorrow or after tomorrow and let you know

Loic691 commented 1 month ago

Hi @petergridge For information Yesterday Next cycle was panned in 3 days ! This morning irrigation cycle was not launching. It's a good news ! Have to wait 2 days to see if issue is solve Thanks

petergridge commented 1 month ago

Good news, you can also provide a sensor directly to the component now. The method is in the documentation

Loic691 commented 1 month ago

Good news, you can also provide a sensor directly to the component now. The method is in the documentation

Great for template sensor. I will wait to check the issue first and will change to template sensor instead of automation

For info in your doc

Start time
You can define the start time using two methods.

You have 3 methods ;-)

Loic691 commented 1 month ago

I found a bug A program was launched and I stoped it manually Here's the capture of the next cycle => 3 minutes AGO Next cycle must be a future date See rt2_relay10_irrigation_maisonouest_next_run: 2024-09-17T10:16:00+02:00 following capture

image

start_time: input_datetime.irrigation_bordure_maison_starttime
run_freq: input_select.irrigation_frequency_bordure_maison
irrigation_on: input_boolean.irrigation_bordure_maison_enabled
show_config: binary_sensor.bordure_maison_config
inter_zone_delay: input_number.irrigation_interzonedelai
remaining: 0:00:00
zone_1_name: rt2_relay01_irrigation_maisonsud
rt2_relay01_irrigation_maisonsud_type: switch
rt2_relay01_irrigation_maisonsud_last_ran: 2024-08-15T12:02:05.375306+02:00
rt2_relay01_irrigation_maisonsud_remaining: 0:00:00
rt2_relay01_irrigation_maisonsud_status: sensor.bordure_maison_rt2_relay01_irrigation_maisonsud_status
rt2_relay01_irrigation_maisonsud_show_config: binary_sensor.bordure_maison_rt2_relay01_irrigation_maisonsud_config
rt2_relay01_irrigation_maisonsud_zone: switch.rt2_relay01_irrigation_maisonsud
rt2_relay01_irrigation_maisonsud_water: input_number.irrigation_duree_plantes_maison_sud
rt2_relay01_irrigation_maisonsud_rain_sensor: binary_sensor.irrigation_rain_sensor_bordure_maison
rt2_relay01_irrigation_maisonsud_enable_zone: input_boolean.irrigation_zone1_enabled
zone_2_name: rt2_relay10_irrigation_maisonouest
rt2_relay10_irrigation_maisonouest_type: switch
rt2_relay10_irrigation_maisonouest_last_ran: 2024-09-15T09:52:00.001638+02:00
rt2_relay10_irrigation_maisonouest_remaining: 0:00:00
rt2_relay10_irrigation_maisonouest_status: sensor.bordure_maison_rt2_relay10_irrigation_maisonouest_status
rt2_relay10_irrigation_maisonouest_show_config: binary_sensor.bordure_maison_rt2_relay10_irrigation_maisonouest_config
rt2_relay10_irrigation_maisonouest_zone: switch.rt2_relay10_irrigation_maisonouest
rt2_relay10_irrigation_maisonouest_water: input_number.irrigation_duree_maison_ouest
rt2_relay10_irrigation_maisonouest_rain_sensor: binary_sensor.irrigation_rain_sensor_bordure_maison
rt2_relay10_irrigation_maisonouest_enable_zone: input_boolean.irrigation_zone10_enable
zone_count: 2
rt2_relay01_irrigation_maisonsud_next_run: disabled
rt2_relay10_irrigation_maisonouest_next_run: 2024-09-17T10:16:00+02:00
friendly_name: Bordure Maison
petergridge commented 1 month ago

Hi V2024.09.04 has some significant changes that improve the card performance.

Would you like to help with some translation to French? If you can translate these it will provide a better experience.

    "off": "Off",
    "on": "On",
    "disabled": "Disabled",
    "pending": "Pending",
    "eco": "ECO",
    "program_disabled": "Program disabled",
    "controller_disabled": "Controller disabled",
    "unavailable": "Unavailable",
    "raining": "Raining",
    "adjusted_off": "Adjusted off",
    "no_water_source": "No water source detected"
Loic691 commented 1 month ago

Oh Yeah

"off": "Arrêt",
"on": "Marche",
"disabled": "Désactivé",
"pending": "En attente",
"eco": "ECO",
"program_disabled": "Programme désactivé",
"controller_disabled": "Contrôleur désactivé",
"unavailable": "Indisponible",
"raining": "Pluie",
"adjusted_off": "Aucun ajustement",
"no_water_source": "Source d'eau non détectée"
petergridge commented 1 month ago

Hi V2024.09.05 has been uploaded with the French translations.

I'll close this issue odd now. Just raise a new one if you find new issues.

Loic691 commented 1 month ago

For the moment it seams OK but weather is rainy so I have to wait... Don't try to stop a program which is running... Do you see my post here ? https://github.com/petergridge/Irrigation-V5/issues/83#issuecomment-2354859985 Do you find anything wich can cause this ?