search

petergtz / pegomock

Pegomock is a powerful, yet simple mocking framework for the Go programming language
Apache License 2.0
252 stars 28 forks source link

Change to Github Kingpin #115

Closed jpopadak closed 3 years ago

jpopadak commented 3 years ago

Any chance the dependency on Kingpin can be changed to its GitHub equivalent? Doing anything with gopkg.in causes issues with Go modules & using a 3rd party Module Vendor.

https://github.com/alecthomas/kingpin/

For my local code, we have been using: replace gopkg.in/alecthomas/kingpin.v2 => github.com/alecthomas/kingpin v2.2.6

petergtz commented 3 years ago

Hey @jpopadak, yes, definitely. Sorry, I didn't realize there was an issue. Would mind submitting a PR with the change? I'll be happy to merge it. Thanks, Peter

jpopadak commented 3 years ago

I am 90% sure this is an issue with our GOPROXY we are using. Kingpin itself states to use gopkg.in/alecthomas/kingpin.v2 itself. 🤷🏼

petergtz commented 3 years ago

So what should we do? Will you investigate your GOPROXY settings, or would you prefer to use github.com/alecthomas/kingpin? If the latter, would you mind submitting a PR? If the former, should we close this issue and re-open if necessary?

jpopadak commented 3 years ago

Lets close this for now. If it turns out to be an issue outside of our GOPROXY, I wil reopen.