search

petergtz / pegomock

Pegomock is a powerful, yet simple mocking framework for the Go programming language
Apache License 2.0
254 stars 28 forks source link

Generated test files should be committed to the repository #95

Closed jpopadak closed 4 years ago

jpopadak commented 5 years ago

Description go mod tidy fails on projects that have Pegomock as a dependency when using Go 1.13.

According to the Go team, all generated files (including tests) should be committed to each repository.

Resolution Commit all test generated files to the repository according to the Golang team: https://github.com/golang/go/issues/34514

petergtz commented 5 years ago

@jpopadak Just made this change last week 🙂. See here: https://github.com/petergtz/pegomock/commit/7fe43e1b91ec13f6cefed612880a4f43939f9da8

I have just not merged it to master yet, but will do some time this week. Feel free to try it out on develop.

jpopadak commented 5 years ago

Sounds awesome. Look forward to it getting merged. :)

petergtz commented 4 years ago

You should have it now. Enjoy! Closing.