petergu684 / HoloLens2-ResearchMode-Unity

Unity Plugin for using research mode functionality in HoloLens 2. Modified based on HoloLens2ForCV.
MIT License
202 stars 59 forks source link

Long throw sensor Point Cloud? #18

Closed vbandi closed 2 years ago

vbandi commented 3 years ago

Hi,

I'd like to request a way to get the point cloud for the long throw sensor. I had a look at HL2ResearchMode::DepthSensorLoop, and I think I found where to do it, but I'm not a C++ dev and can barely understand what's going on. The code seems to be written around the short throw sensor, and thus modifying it to include the long throw sensor for point cloud is beyond what I'm able to do.

I understand that the key is to use MapImagePointToCameraUnityPlane, which also exists for the long depth sensor.

Zulex commented 3 years ago

@vbandi Did you manage to do this? I have the exact same issue.

vbandi commented 3 years ago

@Zulex nope.

petergu684 commented 2 years ago

I may try to do it later but I suppose it should be pretty similar to the short throw one?

vbandi commented 2 years ago

@petergu684 yes - unfortunately I'm not good enough in C++ to do it without pulling out my remaining hair. :( I'm more than happy to help with the Unity side though: https://github.com/vbandi/HL2-ResearchMode

petergu684 commented 2 years ago

Added :)

vbandi commented 2 years ago

@petergu684 yohooo! I'll check it soon.

vbandi commented 2 years ago

Thanks! Works well, submitted a PR with a small fix. I see some crashes in my app when turning off the depth sensor altogether, but couldn't find the cause yet.

Sindhu2k3 commented 2 weeks ago

Hi,

I'd like to request a way to get the point cloud for the long throw sensor. I had a look at HL2ResearchMode::DepthSensorLoop, and I think I found where to do it, but I'm not a C++ dev and can barely understand what's going on. The code seems to be written around the short throw sensor, and thus modifying it to include the long throw sensor for point cloud is beyond what I'm able to do.

I understand that the key is to use MapImagePointToCameraUnityPlane, which also exists for the long depth sensor.

I am facing the same issue. if the problem is solved could you please guide me through it