Closed complyue closed 5 years ago
I tested on windows and added compatibility updates, changing prompt on-the-fly seems not working, maybe the line clearing issue? At least it runs on windows with no error.
Thanks for taking the time to experiment. Please accept my apologies for taking so long to review this pull request. Unfortunately, there are a lot of issues with this pull request:
All that aside, the main problem with this pull request is that I've changed my opinion since my comments in #16 and #46. I no longer think this feature is appropriate, regardless of how carefully it has been implemented. If you want "print above prompt", you want a different library than this one. I will not be accepting a pull request that adds such a feature. At most, I could accept a pull request that adds a link in README.md that points to other libraries that support this feature (whether a fork of liner or an entirely unrelated library).
This may fix #16 #46 and less racy, tho I don't know how it'll work on windows.