allow turning off beep - Githubissues

peterh / liner

Pure Go line editor with history, inspired by linenoise

MIT License

1.05k stars 132 forks source link

Closed quite closed 4 years ago

quite commented 4 years ago

I'd like an option to turn off the beeping. Would a func (s *State) SetBeep(bool) do? Default true.

peterh commented 4 years ago

I wouldn't reject a pull request, but I would prefer you to turn off the beep in xterm (or whatever you're using) instead of liner.

quite commented 4 years ago

I think it makes sense to allow programs that use liner to be able to control the beeping (for example to make it configurable). See #125

peterh commented 4 years ago

Merged #125 . Thanks for the patch.