peterh / liner

Pure Go line editor with history, inspired by linenoise
MIT License
1.05k stars 132 forks source link

Weird behaviour with multi-line and history #150

Open Isolus opened 3 years ago

Isolus commented 3 years ago

When I run the following minimal example on Manjaro Linux / xfce4-terminal (0.8.10) or on Mac OS X 10.14.6 / Terminal

package main

import "github.com/peterh/liner"

func main() {

    line := liner.NewLiner()
    defer line.Close()

    line.SetMultiLineMode(true)

    for {
        input, _ := line.Prompt("> ")
        line.AppendHistory(input)
        if input == "exit" {
            break
        }
    }

}

and enter a short line, a long line which extends to a second line and then recall the first line from history with the up key and press enter, there is an additional blank line (the one before the exit) which shouldn't be there.

> s=1
> s=fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
fff
> s=1

> exit

The prompt seems to jump one line up while going over the two line history entry which somehow creates the extra newline. If the multi line entry spans several lines you get even more blank lines.

peterh commented 3 years ago

Ping @flisky