search

peterh / liner

Pure Go line editor with history, inspired by linenoise
MIT License
1.05k stars 132 forks source link

Ctrl r search #21

Closed ElPincheTopo closed 10 years ago

ElPincheTopo commented 10 years ago

The functionality for the bash-like, ctrlR search. With ctrlR you start the search prompt, and then use ctrlR ctrlS to navigate through the history.The search looks for lines in history that match what you are typing in any part of the line.

This does not copy all the functionality from the readline ctrlR, but I think it is a great first start.

There are few changes but a lot of commits, this is because sometimes I commit and push even if something is not finished to be able to download it at home and continue working there.

peterh commented 10 years ago

You can fix it easily with "git rebase -i". And while you're in there, could you please clean up the rest of the history? With typo fixes and such interspersed, it's unclear whether (for example) "Only refresh at the end" is necessary for this to function, or if it's an unrelated cleanup.

ElPincheTopo commented 10 years ago

Fixed the history :D

peterh commented 10 years ago

I liked it better when the Ctrl-X changes were a separate commit. But now I'm just nitpicking.

I'm not sure how often I'll use Ctrl-R, but it's very useful when you need it. Thanks for the patch. Pulled.