search

peterh / liner

Pure Go line editor with history, inspired by linenoise
MIT License
1.05k stars 132 forks source link

Hardcoded "^C" Println when pressing ctrl+c #69

Closed martinpinto closed 6 years ago

martinpinto commented 8 years ago

It could be nice to have the hardcoded "^C" print removed when pressing ctrl+c. I would like the decision whether to print out "^C" handed out to the user.

peterh commented 8 years ago

liner was supposed to be opinionated. It has become less so lately, so I'm not going to rule out a flag to make printing "^C" optional. But I do want to see a better reason than "It could be nice" in the pull request.

martinpinto commented 8 years ago

I am using liner in a project and I want a clean ctrl+c without the print (e.g. like redis-cli). A flag sounds nice

peterh commented 8 years ago

Consistency with other applications is a reasonable goal. I look forward to reviewing your pull request.

filimonov commented 6 years ago

@martinpinto Please take a look on #102 Is that what you expect ?

peterh commented 6 years ago

@filimonov Thanks for the pull request.

@martinpinto Are you still interested in this feature? If not, I'm not going to pull it. Every added API is an additional maintenance burden.

martinpinto commented 6 years ago

I'm not using liner anymore. You can close this

peterh commented 6 years ago

@filimonov Thanks again for the pull request. But if there are no users, I'm uninterested in the maintenance burden of additional API.

If anyone else wants this in the future, please reference pull request #102.