search

peterhajas / MobileNotifier

iOS Notifications. Done right.
BSD 3-Clause "New" or "Revised" License
302 stars 32 forks source link

Changed keyboardtype and lockscreen behavior #265

Closed Drudoo closed 13 years ago

Drudoo commented 13 years ago

I have changed the keyboardtype to UIKeyboardAppearanceAlert to get the transparent keyboard. Screenshot: http://cl.ly/3B032f042J1v230O1s1b

Changed Lockscreen from using alertTableViewDataSource to alertTableViewDataSourceEditable this makes the tableview editable and then I added didSelectRowAtIndexPath so we can go from our Lockscreen directly to our app.

Screenshot: http://cl.ly/0i3r1H30251u3L2T300h

There is a lot of Commits but it is just a few things, which have been tested back and forth =)

timnovinger commented 13 years ago

@Drudoo - I will test this out tonight. I just built it and installed it onto my phone.

I like the idea of the keyboard style change, but I'm very hesitant about making the lockscreen notification table editable as it introduces issues.

neelo commented 13 years ago

This is great news If only you can get permission off Peter to upload your betas to a repo for the people who cannot build this

timnovinger commented 13 years ago

Unfortunately this still needs some work before it's perfect. Here are the issues that I've noticed:

In the meantime I'm going to add in the keyboard style change since it's just one line (unfortunately I'll have to commit this myself since I can't pull just that out of your pull request).

Thanks for the help, and hopefully you can solve the issues with this feature!

BDudely commented 13 years ago

When I look at all this code i just see beautiful, beautiful, updates;)

ghost commented 13 years ago

not to be pushy or anything, but does this also fixes the notification bug, when you get a popup and reply to a message to clear the notification badge on the SMS app?

timnovinger commented 13 years ago

Nope @unknownsolo, that is a completely separate issue altogether.

Tim Novinger

Twitter: @timnovinger Skype: tim.novinger Mobile: 260.918.4937

Web: timnovinger.com

Sent with Sparrow (http://www.sparrowmailapp.com)

On Wednesday, June 1, 2011 at 12:24 AM, unknownsolo wrote:

not to be pushy or anything, but does this also fixes the notification bug, when you get a popup and reply to a message to clear the notification badge on the SMS app?

Reply to this email directly or view it on GitHub: https://github.com/peterhajas/MobileNotifier/pull/265#issuecomment-1272067

Drudoo commented 13 years ago

Thanks for the comments. After reading Tim's and Peter's comment, on issue #45, I will have to agree with both of you. I can see the problem with the Lockscreen and the way iOS is working. In this stage of development I can see that we have bigger issues and I will let the Lockscreen rest for a bit. I think the Lockscreen view needs a bit of a graphic change. The TableView should not be higher than the rows needed to display the notifications, that counts for the Dashboard too, so we don't have the transparent black background all over the screen. As for new modifications I think the Dashboard need to me fully working before the Lockscreen goes into heavy development. There is a big problem with dismissing the screen when not using the Switcher. When the Dashboard is shown at the Switcher there is a problem with Music Control Pro.

As for the strange space whitespace commits i have no idea. Github shouldn't report those :/ I will try to make smaller pull request next time, so you can merge it ;)

The next thing i will focus on is the badge clearing, which is REALLY annoying, and better functions for the dashboard.

timnovinger commented 13 years ago

@drudoo Sorry we couldn't merge this code in, but your help is very appreciated. Keep up the good work dude!