search

peterhajas / MobileNotifier

iOS Notifications. Done right.
BSD 3-Clause "New" or "Revised" License
302 stars 32 forks source link

Notification tones fixed #279

Closed sammargh closed 13 years ago

sammargh commented 13 years ago

Notifications work properly now based off the user settings within the iPhone. Of course this will break if a hacker decides to use their own custom setting, they get Tritone.

timnovinger commented 13 years ago

So this doesn't take into account the new tones that Apple just introduced for SMS not too long ago?

Drudoo commented 13 years ago

Sweet. Just tested and it works perfectly. @timnovinger doesn't look like it, but it could probably be fixed quickly, if you get the right AudioServicesPlayAlertSound code for each of them.

sammargh commented 13 years ago

Derp. I can add those in. Hold on.

sammargh commented 13 years ago

http://www.iphonedevwiki.net/index.php/AudioServices

that's the list of audio tones and the respective codes.. just use those so I don't have to initiate another pull request

sammargh commented 13 years ago

There's the full set of notification tones

timnovinger commented 13 years ago

Awesome job dude, you rock!

It's a little interesting that Apple neglected IDs 1011 and 1012 and went straight to 1013, lol.