peterhil / spellbook

Spellbook is a WebExtension to easily add new bookmarks to correct categories
Mozilla Public License 2.0
29 stars 2 forks source link

Wrong page information shown on popup #1

Closed peterhil closed 5 years ago

peterhil commented 5 years ago

When inactive page changes title or url, the popup information is wrong

Websites that change the window title on notifications cause the popup to show information for the page that was last changed – even if it is not the active one.

issue 1 wrong page information on notifications

Technical analysis

The bug is caused by currentTab stream not properly filtering these changes out. Or in other words, it should only emit events on user generated changes.

Suggested solution

The solution is to make sure that only user generated changes to title or url pass the filtering on currentTab stream.