Make CategorySelector code elegant - Githubissues

peterhil / spellbook

Spellbook is a WebExtension to easily add new bookmarks to correct categories

Mozilla Public License 2.0

29 stars 2 forks source link

Make CategorySelector code elegant #63

Closed peterhil closed 3 years ago

peterhil commented 3 years ago

Make CategorySelector code elegant and use single responsibility principle.

Currently the responsibilities are:

Handle category selections (selection) – make this into only new responsibility
Dropdown visibility ($showDropdown)
Searching categories (search) – even though there is CategorySearch component already!
Showing search results (lastSearch, searchResults)
Adding subcategories

Cleanup:

[x] Fix dropdown logic to use a store #47
[x] Move subcategory into BookmarkForm

Tasks:

[x] Extract adding subcategories into separate component
[x] Handle search using a store
[x] Make category selection the only responsibility

Make it a container component:

[x] Make CategorySelector a container component (like tabs or menu)