RFC The main branch

[peterhinch]

@bobveringa I hope you had an enjoyable break.

I have given some thought to the changes on the read_allocate branch. I think, once you've ironed out any issues in your application, these should be merged. These are the main considerations.

• Using a dynamically sized pre-allocated buffer for ._as_read substantially reduces allocations.
• Copying of incoming messages is essential in the case of the event interface.
• In the case of the callback interface copying should be the default, which can be overridden for special use cases. The defaults is to avoid breaking code; also because passing a memoryview can cause concurrency bugs if a callback launches tasks.
• If we are to merge this we should consider some refactoring in an attempt to reduce RAM usage, especially in __init__.py.

Re refactoring, I suggest you watch this short video by Damien George on MicroPython optimisation. This will explain why MicroPython code tends to differ from "big iron" Python, notably in object naming. My main concern is __init__.py because of the use of V3.1.1 on ESP8266, which is extremely RAM-constrained. You might also want to consider these issues in mqtt_v5_properties.py.

Like all optimistion, this may be done late, once we have a solution that meets your needs.

[bobveringa]

This looks like a clear approach.

Once I have some more time I can investigate this refactoring issue.

[peterhinch]

I am happy to do the refactoring of __init__.py - I have quite a lot of experience with MP coding. The main issues are object names and cacheing of variables. The video will clarify the reasoning.

Talk next week :)