peterhinch
commented
7 months ago I'm sorry but I can't accept this. My device drivers have been tested on hardware that I own. Waveshare have re-published my code on their site. I should point out that they do this with attribution and they are entirely within their rights to do this. But it does mean that their code lags behind mine. In the past it has taken some time for improvements and bugfixes to be incorporated. Drivers such as the one in this PR are authored by Waveshare. If I were to incorporate them in my repo I would be falling into exactly the same trap: I'd need to regularly monitor their code to see if anything had been fixed or improved.
I would also expose myself to issues being raised against the code: without hardware I couldn't progress these. Further I have no means of knowing how extensively Waveshare have tested their driver. For example has the asynchronous code been tested?
Hopefully you can see why, from my point of view, this is a non-starter. Sorry.
I have included a note in DISPLAYS.md to point out the existence of additional Waveshare drivers, on a "use at your own risk" basis.
As a general point a good PR would include additional support. An ePaper driver would need documentation (with discussion of partial refresh performance), and a setup example as a minimum.
This pull request adds fpt_mono.py in demos folder with support for the Waveshare 2.13inch E-Paper Module for Raspberry Pi Pico. It is a variation/simplification of fpt.py replacing CWriter with Writer and removing colour arguments.
It also adds the relevant driver from https://github.com/waveshareteam/Pico_ePaper_Code.
I found it difficult/time consuming to get fplot working on my e-paper screen for my project, primarily due to no black and white demo. I hope this helps someone else.
Please review these changes and provide feedback. This is my first ever pull request!