peterhinch / micropython-samples

Assorted code ideas, unofficial MP FAQ, plus index to my other repositories.
MIT License
442 stars 91 forks source link

Encoders #24

Closed IhorNehrutsa closed 2 years ago

IhorNehrutsa commented 2 years ago

Hi Peter. May you add two files from #23 ? encoders/encoder_state.py - another IRQ-based Encoder() realisation encoders/encoders_test.py - simple test prog without changes to any other files.

I have added two links micropython-samples/encoders from https://github.com/micropython/micropython/pull/6639/files#diff-d8ed2c8e50000722c4ba84e2bf8ec4c669470612286a143116e4679214dd8463

peterhinch commented 2 years ago

As I explained, one purpose of these samples is to illustrate an algorithm that doesn't use a state machine. I suggest you publish your own repo: I'm not criticising this code which is a fine solution, merely pointing out that it doesn't fit with the objectives of my samples.