search

peterhn / cs121-crawler

web crawler for ics.uci.edu
0 stars 0 forks source link

Hardcoded file names #1

Closed pyamsoft closed 9 years ago

pyamsoft commented 9 years ago

In a couple of the files, there are multiple instances of hardcoded path strings for a specific machine.

Please create a public variable in the main class which will contain the path string. This will make it easier for others to adopt the code as we won't have to dig around the project looking for each instance of the hardcoded path on our specific machines.

Can submit a pull request if you want, but its not the largest problem at the moment.

peterhn commented 9 years ago

Yeah sure sounds good. Would you also be able to meet tomorrow?

Peter

On Apr 20, 2015, at 10:13 AM, pyamsoft notifications@github.com wrote:

In a couple of the files, there are multiple instances of hardcoded path strings for a specific machine.

Please create a public variable in the main class which will contain the path string. This will make it easier for others to adopt the code as we won't have to dig around the project looking for each instance of the hardcoded path on our specific machines.

Can submit a pull request if you want, but its not the largest problem at the moment.

— Reply to this email directly or view it on GitHub.

pyamsoft commented 9 years ago

I am available after 3pm