search

peterjc / flake8-black

flake8 plugin to run black for checking Python coding style
MIT License
166 stars 10 forks source link

pipenv version clash workaround #22

Closed peterjc closed 4 years ago

peterjc commented 4 years ago

Should resolve issues #18 / #21 with the least bad workaround. I consider it unlikely that many people using black and flake8-black would be using anything older than black 19.3b0, which is now over a year old.

@bbenne10 could you look at this please? e.g. Did you have strong reason for suggesting bumping the version of v0.2?

bbenne10 commented 4 years ago

My preference for 0.2 over 0.1.3 is that this isn't an internal bugfix, but is backwards compatible and semver says that's a minor version bump.

Of course, you get to do you. This should work great.

bbenne10 commented 4 years ago

@peterjc: Ping? I'd love to integrate flake8-black on our CI, but am waiting on this PR's merging and the new release to do so. Is there any other feedback you're waiting on from me?

peterjc commented 4 years ago

No, just waiting on a quiet evening - wouldn't rule it out tonight...

bbenne10 commented 4 years ago

I am now integrating this into a project at work and can confirm that the unbound black version is indeed fixing the problem with pipenv.

Thanks again for the swift response!