Closed rsalmaso closed 2 years ago
Very much needed, as for some reason something in our dependency tree already forces black to >=22 and this breaks all builds.
+1 on the need for this. All sqlfluff
PRs are blocked from merging to main
, because this incompatibility makes us fail our linting tests: https://github.com/sqlfluff/sqlfluff/runs/4994690193?check_suite_focus=true . Is there a way we can get a maintainer to review and approve this change quickly?
It's Sunday :smiley_cat: (I wrote this patch on Saturday night - UTC+01), and I don't expect anything at least before Monday (and I don't know the maintainer's timezone).
I can suggest to pin black if possible, otherwise you could install this PR directly with
pip install git+https://github.com/peterjc/flake8-black.git@refs/pull/43/head
(ok, this is the last resort if you need black stable and and a working environment)
If pinning is impossible for you that’s a shame. I will probably get to this tonight (Sunday evening).
Are you happy to be thanked by name @rsalmaso ?
If pinning is impossible for you that’s a shame. I will probably get to this tonight (Sunday evening).
If you happen to be able to receive some sort of micro donations somewhere, feel free to share details.
Fixing issues for downstream on a weekend should be appreciated with a gratis coffee at least.
Are you happy to be thanked by name @rsalmaso ?
As you wish, it is fine for me. Thanks
Thank you all for taking care of this so quickly!!!
New
black
22.1.0 breaksflake8-black
withBecause it update
find_project_root
return values: fromPath
toTuple[Path, str]
(https://github.com/psf/black/commit/521d1b8129c2d83b4ab49270fe7473802259c2a2)