search

peterjc / flake8-black

flake8 plugin to run black for checking Python coding style
MIT License
165 stars 10 forks source link

0.3.1 is not able to open files #50

Closed sileht closed 2 years ago

sileht commented 2 years ago

Hi, looks like last release as an issue with opening files.

For all files flake8-black reports:

`BLK999` Unexpected exception: File must be opened in binary mode, e.g. use `open('foo.toml', 'rb')`
tommyjcarpenter commented 2 years ago

We also cannot run this on any files due to this issue, I've pinned to 0.3.0 for now

peterjc commented 2 years ago

Yanked, newer versions of tomli broke this.

peterjc commented 2 years ago

Fixed with v0.3.2, in hindsight I really should have started with fixing #34 today. Sigh.

timkpaine commented 2 years ago

@peterjc thanks for the quick fix!

peterjc commented 2 years ago

Apologies to you and the other people caught out today. The only bright side is I'd previously learnt the hard way never to schedule a release Friday afternoon (European time), on the off chance it goes wrong. Like today, I broke stuff Friday morning and had Friday afternoon to fix it 😂

zyv commented 2 years ago

@peterjc thanks for taking care of this so quickly!

timkpaine commented 2 years ago

@peterjc no worries, if you're like me and just pin >= then periodic breakages are just a part of life 😄

tommyjcarpenter commented 2 years ago

Thank you! Much appreciated @peterjc