search

peterjc / flake8-black

flake8 plugin to run black for checking Python coding style
MIT License
165 stars 10 forks source link

Recursively include tests/ in distribution #54

Closed polyzen closed 2 years ago

polyzen commented 2 years ago

The 0.3.2 release on PyPI does not have the commas and black_preview files added since the 0.2.4 release. Perhaps this is needed?

peterjc commented 2 years ago

Perhaps yes, the tar-ball should include the tests. Although I would want to enhance the GitHub Actions to actually test this, and I lean to a more explicit manifest over grafting (to avoid accidental inclusion of files on the developer's working repository).

What I normally do is build the wheel and tar-ball, locally install the wheel, unzip the tarball, cd into the decompressed tarball, and run the tests there. This catches an incomplete manifest.

polyzen commented 2 years ago

So what should be done here?

polyzen commented 2 years ago

I'm not sure what building a tarball entails here.

peterjc commented 2 years ago

The command python setup.py sdist --formats=gztar makes a Python source distribution tar-ball.

What I wanted was to replicate my release process (and test it), which is currently documented here:

https://github.com/peterjc/flake8-black#developers