search

peterjc / flake8-black

flake8 plugin to run black for checking Python coding style
MIT License
165 stars 10 forks source link

CI workflow on Windows, macOS, and Ubuntu #56

Closed eggplants closed 2 years ago

eggplants commented 2 years ago

To check compatibility of major environments, I modified CI and test files so that they could be run on mac and windows.

peterjc commented 2 years ago

That's looking much cleaner now :)

peterjc commented 2 years ago

Got the plain diff to work - see https://github.com/peterjc/flake8-black/commits/win_mac_ci

It seems git config core.autocrlf false was needed but I don't understand why. Perhaps it has to do with running bash on Windows?

eggplants commented 2 years ago

Got the plain diff to work - see https://github.com/peterjc/flake8-black/commits/win_mac_ci

It seems git config core.autocrlf false was needed but I don't understand why. Perhaps it has to do with running bash on Windows?

!!! I haven't known this behavior! I cannot explain why too. Could you add your commits to here?

peterjc commented 2 years ago

I was expecting git config core.autocrlf auto or git config core.autocrlf true to be appropriate, but that didn't work. I didn't expect git config core.autocrlf false to work but tried it anyway.

I can try updating this branch...

peterjc commented 2 years ago

Rebased, and trying without the git reset --hard (might need that too)

peterjc commented 2 years ago

Are you OK with the modified branch being merged?

(You can force push your original if you'd rather we keep more of the history)

eggplants commented 2 years ago

Are you OK with the modified branch being merged?

(You can force push your original if you'd rather we keep more of the history)

Ready for merge.

peterjc commented 2 years ago

Merged, thank you!