Closed peterjc closed 9 years ago
Thanks for filling this issue! I don't think having identical copies of these quite static files would be a problem. Tell me if you want me to prepare a pull request
Does that work for you @abretaud? Assuming there are no obvious problems this will eventually reach the Test Tool Shed, then main Tool Shed.
Yes, it looks perfect! I will retest it once it is in Test Tool Shed, just to be sure, but it should be ok Thanks!
Great. Do you need this soon? i.e. Would a release in the next week or so be ideal?
I'm currently trying to take advantage of this work and other updates in the Galaxy test framework for #53 ...
It's not very urgent, though I'm waiting for it to be released before releasing the biomaj code I have written. In fact I'm on holidays at the end of next week until January 5th, so if you have time to release it next week it's great, otherwise it's not a big problem, it will wait until january
See discussion on #22, from where I have copied most of the description here.
Should we start using Data Tables to access the BLAST database
*.loc
files? See https://wiki.galaxyproject.org/Admin/Tools/Data%20Tablesi.e. Replace this in our macros file:
With the shorter:
The column information is then instead defined via
tool-data/tool_data_table_conf.xml.sample
:Quoting @blankenberg on the Galaxy mailing list:
See http://lists.bx.psu.edu/pipermail/galaxy-dev/2014-April/019027.html - and the Trello Issue https://trello.com/c/VZxV08Qt which says:
It looks like we could have identical copies of the tool-data/tool_data_table_conf.xml.sample and the tool-data/*.loc.sample files included in multiple ToolShed repositories. They should be almost static so version clashes should not be a problem?
See http://lists.bx.psu.edu/pipermail/galaxy-dev/2014-April/019023.html / http://dev.list.galaxyproject.org/Data-Tables-and-loc-files-Using-named-columns-versus-from-data-table-tc4664149.html and the Trello Card on Galaxy: https://trello.com/c/VZxV08Qt