peterjokumsen / peterjokumsen-nx-workspace

Project to use as a blog, to test out development theories and document stuff.
https://blog.peterjokumsen.com
GNU General Public License v3.0
1 stars 0 forks source link

fix(ng-services): improve image path resolution for markdown #144

Closed peterjokumsen closed 2 months ago

peterjokumsen commented 2 months ago

Summary

After attempting to use PjMarkdownClient, found that images with - in filename are not correctly updated.

Changes Made

Updated regular expression used to adjust paths for images.

Checklist

nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fd52968eea234b35618a33b4f7f2095506e8df76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 2 targets - [`nx affected -t lint test --configuration=ci --base=f91e45a295185509ab846a09034ef8b3994121d4`](https://cloud.nx.app/runs/P75rPIzLtm?utm_source=pull-request&utm_medium=comment) - [`nx run blog:build:staging`](https://cloud.nx.app/runs/SeCfP0KJsl?utm_source=pull-request&utm_medium=comment)

Sent with πŸ’Œ from NxCloud.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (f91e45a) to head (fd52968). Report is 1 commits behind head on main.

Files Patch % Lines
...arkdown-client/services/markdown-parser.service.ts 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files | [Files](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | Coverage Ξ” | | |---|---|---| | [...arkdown-client/services/markdown-parser.service.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144?src=pr&el=tree&filepath=ng-libs%2Fservices%2Fsrc%2Flib%2Fpj-markdown-client%2Fservices%2Fmarkdown-parser.service.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-bmctbGlicy9zZXJ2aWNlcy9zcmMvbGliL3BqLW1hcmtkb3duLWNsaWVudC9zZXJ2aWNlcy9tYXJrZG93bi1wYXJzZXIuc2VydmljZS50cw==) | `87.50% <50.00%> (-5.84%)` | :arrow_down: | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | [Components](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | Coverage Ξ” | | |---|---|---| | [md-parser](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `βˆ… <ΓΈ> (βˆ…)` | | | [ts-libs](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `βˆ… <ΓΈ> (βˆ…)` | | | [md-renderer](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `85.67% <ΓΈ> (ΓΈ)` | | | [module_ng_libs](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `92.51% <50.00%> (-0.37%)` | :arrow_down: | | [app_blog](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `89.91% <ΓΈ> (ΓΈ)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). Last update [f91e45a...fd52968](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/144?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen).
github-actions[bot] commented 2 months ago

πŸ¦™ MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
βœ… ACTION actionlint 7 0 0.16s
βœ… COPYPASTE jscpd yes no 1.88s
βœ… EDITORCONFIG editorconfig-checker 426 0 1.45s
βœ… JSON jsonlint 77 0 0.38s
βœ… JSON npm-package-json-lint yes no 0.76s
βœ… JSON prettier 77 0 3.41s
βœ… JSON v8r 77 0 119.01s
βœ… MARKDOWN markdownlint 22 0 1.04s
βœ… MARKDOWN markdown-link-check 36 0 5.64s
⚠️ MARKDOWN markdown-table-formatter 36 1 0.46s
βœ… REPOSITORY checkov yes no 42.49s
βœ… REPOSITORY gitleaks yes no 1.86s
βœ… REPOSITORY git_diff yes no 0.04s
βœ… REPOSITORY secretlint yes no 1.77s
βœ… REPOSITORY trivy yes no 19.95s
βœ… REPOSITORY trivy-sbom yes no 2.89s
βœ… REPOSITORY trufflehog yes no 38.82s
βœ… SPELL cspell 428 0 6.98s
βœ… XML xmllint 1 0 0.01s
βœ… YAML prettier 14 0 2.4s
βœ… YAML v8r 14 0 19.29s
βœ… YAML yamllint 14 0 0.58s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 2 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-flower-05318b203-144.westeurope.5.azurestaticapps.net

github-actions[bot] commented 2 months ago

⚑️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 74 🟒 95 🟒 96 🟒 88 Report
/about-me 🟒 96 🟒 96 🟒 96 🟒 88 Report
/development-notes 🟒 96 🟒 96 🟒 96 🟒 88 Report
/not/found 🟒 96 🟒 95 🟒 96 🟒 88 Report