peterjokumsen / peterjokumsen-nx-workspace

Project to use as a blog, to test out development theories and document stuff.
https://blog.peterjokumsen.com
GNU General Public License v3.0
1 stars 0 forks source link

chore: remove unused component #147

Closed peterjokumsen closed 2 months ago

peterjokumsen commented 2 months ago

Summary

Found thatfull-page-loader.component is not used anywhere.

Removed it and all usages.

github-actions[bot] commented 2 months ago

πŸ¦™ MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
βœ… ACTION actionlint 7 0 0.11s
βœ… COPYPASTE jscpd yes no 1.88s
βœ… EDITORCONFIG editorconfig-checker 431 0 1.1s
βœ… JSON jsonlint 77 0 0.32s
βœ… JSON npm-package-json-lint yes no 0.72s
βœ… JSON prettier 77 0 3.59s
βœ… JSON v8r 77 0 123.3s
⚠️ MARKDOWN markdownlint 23 3 1.72s
βœ… MARKDOWN markdown-link-check 37 0 6.42s
⚠️ MARKDOWN markdown-table-formatter 37 1 0.46s
βœ… REPOSITORY checkov yes no 39.53s
βœ… REPOSITORY gitleaks yes no 2.4s
βœ… REPOSITORY git_diff yes no 0.04s
βœ… REPOSITORY secretlint yes no 1.77s
βœ… REPOSITORY trivy yes no 20.22s
βœ… REPOSITORY trivy-sbom yes no 4.52s
βœ… REPOSITORY trufflehog yes no 38.02s
βœ… SPELL cspell 433 0 6.17s
βœ… XML xmllint 1 0 0.01s
βœ… YAML prettier 14 0 2.49s
βœ… YAML v8r 14 0 16.21s
βœ… YAML yamllint 14 0 0.7s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (f6ef870) to head (45b90f8). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...s/ui-elements/src/lib/loading/loading.component.ts 71.87% 8 Missing and 1 partial :warning:
Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | Coverage Ξ” | | |---|---|---| | [...og/src/app/components/header/header.component.html](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=apps%2Fblog%2Fsrc%2Fapp%2Fcomponents%2Fheader%2Fheader.component.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-YXBwcy9ibG9nL3NyYy9hcHAvY29tcG9uZW50cy9oZWFkZXIvaGVhZGVyLmNvbXBvbmVudC5odG1s) | `100.00% <ΓΈ> (ΓΈ)` | | | [...blog/src/app/components/header/header.component.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=apps%2Fblog%2Fsrc%2Fapp%2Fcomponents%2Fheader%2Fheader.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-YXBwcy9ibG9nL3NyYy9hcHAvY29tcG9uZW50cy9oZWFkZXIvaGVhZGVyLmNvbXBvbmVudC50cw==) | `100.00% <100.00%> (ΓΈ)` | | | [apps/blog/src/app/primary.component.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=apps%2Fblog%2Fsrc%2Fapp%2Fprimary.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-YXBwcy9ibG9nL3NyYy9hcHAvcHJpbWFyeS5jb21wb25lbnQudHM=) | `81.48% <100.00%> (-0.67%)` | :arrow_down: | | [...s/src/lib/pj-http-tools/http-call-count.service.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=ng-libs%2Fservices%2Fsrc%2Flib%2Fpj-http-tools%2Fhttp-call-count.service.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-bmctbGlicy9zZXJ2aWNlcy9zcmMvbGliL3BqLWh0dHAtdG9vbHMvaHR0cC1jYWxsLWNvdW50LnNlcnZpY2UudHM=) | `100.00% <100.00%> (ΓΈ)` | | | [ng-libs/services/src/lib/pj-http-tools/index.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=ng-libs%2Fservices%2Fsrc%2Flib%2Fpj-http-tools%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-bmctbGlicy9zZXJ2aWNlcy9zcmMvbGliL3BqLWh0dHAtdG9vbHMvaW5kZXgudHM=) | `100.00% <100.00%> (ΓΈ)` | | | [...-http-tools/interceptors/http-count.interceptor.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=ng-libs%2Fservices%2Fsrc%2Flib%2Fpj-http-tools%2Finterceptors%2Fhttp-count.interceptor.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-bmctbGlicy9zZXJ2aWNlcy9zcmMvbGliL3BqLWh0dHAtdG9vbHMvaW50ZXJjZXB0b3JzL2h0dHAtY291bnQuaW50ZXJjZXB0b3IudHM=) | `100.00% <100.00%> (ΓΈ)` | | | [...rvices/src/lib/pj-http-tools/interceptors/index.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=ng-libs%2Fservices%2Fsrc%2Flib%2Fpj-http-tools%2Finterceptors%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-bmctbGlicy9zZXJ2aWNlcy9zcmMvbGliL3BqLWh0dHAtdG9vbHMvaW50ZXJjZXB0b3JzL2luZGV4LnRz) | `100.00% <100.00%> (ΓΈ)` | | | [...es/src/lib/pj-http-tools/pj-http-tools.provider.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=ng-libs%2Fservices%2Fsrc%2Flib%2Fpj-http-tools%2Fpj-http-tools.provider.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-bmctbGlicy9zZXJ2aWNlcy9zcmMvbGliL3BqLWh0dHAtdG9vbHMvcGotaHR0cC10b29scy5wcm92aWRlci50cw==) | `100.00% <100.00%> (ΓΈ)` | | | [...s/ui-elements/src/lib/loading/loading.component.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?src=pr&el=tree&filepath=ng-libs%2Fui-elements%2Fsrc%2Flib%2Floading%2Floading.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-bmctbGlicy91aS1lbGVtZW50cy9zcmMvbGliL2xvYWRpbmcvbG9hZGluZy5jb21wb25lbnQudHM=) | `71.87% <71.87%> (ΓΈ)` | | | [Components](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | Coverage Ξ” | | |---|---|---| | [md-parser](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `92.87% <ΓΈ> (ΓΈ)` | | | [ts-libs](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `100.00% <ΓΈ> (ΓΈ)` | | | [md-renderer](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `85.67% <ΓΈ> (ΓΈ)` | | | [module_ng_libs](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `90.57% <82.69%> (-1.95%)` | :arrow_down: | | [app_blog](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `91.12% <100.00%> (+0.29%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). Last update [f6ef870...45b90f8](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/147?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen).
github-actions[bot] commented 2 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-flower-05318b203-147.westeurope.5.azurestaticapps.net

github-actions[bot] commented 2 months ago

⚑️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 61 🟒 95 🟒 100 🟒 88 Report
/about-me 🟒 91 🟒 96 🟒 100 🟒 88 Report
/development-notes 🟒 96 🟒 96 🟒 100 🟒 88 Report
/not/found 🟒 95 🟒 95 🟒 100 🟒 88 Report
nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 45b90f82d62298a6ac8541345ec266f796899633. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 2 targets - [`nx affected -t lint test --configuration=ci --base=f6ef8704fdfe248747582bfa3f01259d57a2545b`](https://cloud.nx.app/runs/WYuBpWVbKu?utm_source=pull-request&utm_medium=comment) - [`nx run blog:build:staging`](https://cloud.nx.app/runs/B1TAWaFLFJ?utm_source=pull-request&utm_medium=comment)

Sent with πŸ’Œ from NxCloud.

peterjokumsen commented 2 months ago

This PR got a bit out of hand 🀷🏼 c'est la vie.

github-actions[bot] commented 2 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-flower-05318b203-147.westeurope.5.azurestaticapps.net