peterjokumsen / peterjokumsen-nx-workspace

Project to use as a blog, to test out development theories and document stuff.
https://blog.peterjokumsen.com
GNU General Public License v3.0
1 stars 0 forks source link

fix(blog): only use router animation after initial load #150

Closed peterjokumsen closed 1 month ago

peterjokumsen commented 1 month ago

Summary

Update logic for router animation, when no previous animation applied will not animate.

Changes Made

Expand for additional details ## Screenshots ## Related issues Fixes #149 ## Testing instructions
nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 612c3511b001e1e3ce68cd706c238966adf30abe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 2 targets - [`nx run blog:build:staging`](https://cloud.nx.app/runs/GrnORPoOkK?utm_source=pull-request&utm_medium=comment) - [`nx affected -t lint test --configuration=ci --base=d4bb13395f896e2a6569b70e0f1a92f5dec37b5e`](https://cloud.nx.app/runs/HdCCuiWBGb?utm_source=pull-request&utm_medium=comment)

Sent with πŸ’Œ from NxCloud.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.30%. Comparing base (d4bb133) to head (612c351). Report is 1 commits behind head on main.

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | Coverage Ξ” | | |---|---|---| | [apps/blog/src/app/primary.component.ts](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150?src=pr&el=tree&filepath=apps%2Fblog%2Fsrc%2Fapp%2Fprimary.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen#diff-YXBwcy9ibG9nL3NyYy9hcHAvcHJpbWFyeS5jb21wb25lbnQudHM=) | `84.21% <100.00%> (+1.85%)` | :arrow_up: | ... and [85 files with indirect coverage changes](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | [Components](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | Coverage Ξ” | | |---|---|---| | [md-parser](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `βˆ… <ΓΈ> (βˆ…)` | | | [ts-libs](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `βˆ… <ΓΈ> (βˆ…)` | | | [md-renderer](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `βˆ… <ΓΈ> (βˆ…)` | | | [module_ng_libs](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `βˆ… <ΓΈ> (βˆ…)` | | | [app_blog](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) | `91.30% <100.00%> (+0.25%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). Last update [d4bb133...612c351](https://app.codecov.io/gh/peterjokumsen/peterjokumsen-nx-workspace/pull/150?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Jokumsen).
github-actions[bot] commented 1 month ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-flower-05318b203-150.westeurope.5.azurestaticapps.net

github-actions[bot] commented 1 month ago

πŸ¦™ MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
βœ… ACTION actionlint 7 0 0.14s
βœ… COPYPASTE jscpd yes no 1.91s
βœ… EDITORCONFIG editorconfig-checker 432 0 1.51s
βœ… JSON jsonlint 77 0 0.51s
βœ… JSON npm-package-json-lint yes no 0.77s
βœ… JSON prettier 77 0 4.37s
βœ… JSON v8r 77 0 127.64s
⚠️ MARKDOWN markdownlint 23 3 0.91s
βœ… MARKDOWN markdown-link-check 37 0 6.92s
⚠️ MARKDOWN markdown-table-formatter 37 1 0.46s
βœ… REPOSITORY checkov yes no 45.25s
βœ… REPOSITORY gitleaks yes no 2.25s
βœ… REPOSITORY git_diff yes no 0.08s
βœ… REPOSITORY secretlint yes no 1.8s
βœ… REPOSITORY trivy yes no 20.86s
βœ… REPOSITORY trivy-sbom yes no 5.35s
βœ… REPOSITORY trufflehog yes no 38.16s
βœ… SPELL cspell 434 0 7.36s
βœ… XML xmllint 1 0 0.01s
βœ… YAML prettier 14 0 2.58s
βœ… YAML v8r 14 0 15.95s
βœ… YAML yamllint 14 0 0.57s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 1 month ago

⚑️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟒 95 🟒 95 🟒 100 🟒 88 Report
/about-me 🟠 81 🟒 96 🟒 100 🟒 88 Report
/development-notes 🟒 95 🟒 96 🟒 100 🟒 88 Report
/not/found 🟠 83 🟒 95 🟒 100 🟒 88 Report