Closed peterk87 closed 2 years ago
To keep the code consistent with lots of contributors, we run automated code consistency checks. To fix this CI test, please run:
yaml-lint
npm
then install yaml-lint
(npm install -g yaml-lint
)yamllint $(find . -type f -name "*.yml" -o -name "*.yaml")
Once you push these changes the test should pass, and you can hide this comment :+1:
We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!
Thanks again for your contribution!
@peterk87 I found some bugs from initial test
VCF_FILTER_FRAMESHIFT
display incorrectly NF_FLU:NANOPORE:VCF_FILTER_FRAMESHIFT (ERR6359502|5_NP|null)
. It is caused by https://github.com/peterk87/nf-flu/blob/d94de883b22956a92dc066598e11a4a275633bd3/modules/local/vcf_filter_frameshift.nf#L2
It should be $ref_id
publish_dir/variants
and publish_dir/reference_sequences
, there is a strange folder name [:]
ERR6359501.Segment_1_PB2.MH201221.no_frameshifts
@peterk87 I found some bugs from initial test
* Tag of process `VCF_FILTER_FRAMESHIFT` display incorrectly `NF_FLU:NANOPORE:VCF_FILTER_FRAMESHIFT (ERR6359502|5_NP|null)`. It is caused by https://github.com/peterk87/nf-flu/blob/d94de883b22956a92dc066598e11a4a275633bd3/modules/local/vcf_filter_frameshift.nf#L2 It should be `$ref_id` * In `publish_dir/variants` and `publish_dir/reference_sequences`, there is a strange folder name `[:]` * In MultiQC Report, there is sample name `ERR6359501.Segment_1_PB2.MH201221.no_frameshifts`
Thanks @nhhaidee ! All of these should be fixed in 19698ba
@peterk87 The changes look very good to me and tests passed at my end as well, I think you can release it
Thanks @nhhaidee ! I've made a new release at https://github.com/CFIA-NCFAD/nf-flu/releases/tag/3.1.0
This PR is to prepare a v3 release of the workflow adding a Nanopore analysis subworkflow.
The workflow's name has been changed from
nf-iav-illumina
tonf-flu
and the official repo fornf-flu
will be CFIA-NCFAD/nf-flu going forward.bin/fastq_dir_to_samplesheet.py
for Illumina--input
samplesheet creation from Illumina FASTQ reads directory.fastq
,.fq
,.fastq.gz
,.fq.gz
. Updated CI tests to test for this flexible sample sheet handling.results/pipeline_info/
and.nextflow.log
as artifacts for easier debugging of issues.PR checklist
nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).