search

peterk87 / nf-flu

Influenza genome analysis Nextflow workflow
MIT License
21 stars 17 forks source link

parse_influenza_blast_results.py has two question #19

Closed chendongo closed 4 months ago

chendongo commented 4 months ago

Research

Question about nf-flu

you parse_influenza_blast_results.py has two question 1: count not is counts image 2: update not |= image

peterk87 commented 4 months ago

Hi @chendongo I'm not sure what version or commit you're looking at, but the official repo for nf-flu is at https://github.com/CFIA-NCFAD/nf-flu

  1. |= was added in Python 3.9 via PEP 584 for updating dicts as an alternative to the .update method.

    Update a dict in place: The Obvious Way is to use the update() method. If this proposal is accepted, the |= augmented assignment operator will also work, but that is a side-effect of how augmented assignments are defined. Which you choose is a matter of taste.

  2. If this was an issue, it has been fixed since (https://github.com/CFIA-NCFAD/nf-flu/blob/db8f3e7fdbc55dc823b305bd06e57014195ab3d5/bin/parse_influenza_blast_results.py#L344).