search

peterkh / cumulus

Helps manage AWS CloudFormation stacks
Other
206 stars 40 forks source link

Add Color Highlighting to the Event Status #10

Closed cdodd closed 10 years ago

cdodd commented 10 years ago

Also PEP8 linted the MegaStack.py file.

peterkh commented 10 years ago

Hi Craig,

Thanks for the pull request. Looks pretty good, the linting stuff I've been meaning to do myself for a while.

With highlighting the event status, cool idea, though I'd want to see it configurable via the yaml file (and maybe by command line as well). I think its fine to be on by default but could see situations where I wouldn't want it, for example maybe in the output of a CI build or if someone was parsing the output into something else. Would you mind adding that?

Thanks again

cdodd commented 10 years ago

Ok, I've updated the pull request to read the option 'highlight-output' in the megastack and do highlighting based on that.

I'm not 100% sure on the best way to pass the arg from the command line, but I'll have a look at this tomorrow.

peterkh commented 10 years ago

Thanks Craig, yeah I agree had a quick look and couldn't see a clean way with the current structure.