search

peterkh / cumulus

Helps manage AWS CloudFormation stacks
Other
206 stars 40 forks source link

getting an error when running update on a non changed script #14

Open techlunacy opened 9 years ago

techlunacy commented 9 years ago

i am getting the error: ERROR:boto:400 Bad Request ERROR:boto:{"Error":{"Code":"ValidationError","Message":"No updates are to be performed.","Type":"Sender"},"RequestId":"6ddb2bb8-6570-11e4-805d-5fd52f0eb697"} CRITICAL:cumulus.MegaStack:Unknown error updating stack: BotoServerError: 400 Bad Request {"Error":{"Code":"ValidationError","Message":"No updates are to be performed.","Type":"Sender"},"RequestId":"6ddb2bb8-6570-11e4-805d-5fd52f0eb697"}

well obviously there are No updates are to be performed. but this really shouldn't be an error

peterkh commented 9 years ago

Correct me if I'm wrong, but I'm guessing this is a stack that has a passworded param? If so, its because cumulus doesn't know that it hasn't changed until it tries...

techlunacy commented 9 years ago

sorry no passworded params.

acaire commented 9 years ago

Either way, the error response is from Boto, not Cumulus.

peterkh commented 9 years ago

Without passworded fields cumulus should never be trying to do an update unless it believes there is a change. If its doing that, then its a bug. Can you do some digging into what it thiks has changed?

Have a look at https://github.com/cotdsa/cumulus/blob/master/cumulus/MegaStack.py#L238 thats the line that should be preventing updates without changes.

techlunacy commented 9 years ago

ok i have figured out what my problem is. https://github.com/cotdsa/cumulus/blob/master/cumulus/CFStack.py#L201

is comparing the cumulus params with the existing cloudformation params.

i have set up default values in the cloudformation scripts and dont reference them in the cumulus scripts.

this causes a conflict. and causes it to try and update an otherwise unchanged script