peterknife / boto

Automatically exported from code.google.com/p/boto
0 stars 0 forks source link

Wiki page example confusing or wrong #241

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. read source at http://code.google.com/p/boto/wiki/BackupDirectoryToBucket

What is the expected output? What do you see instead?

Opening code reads

        if s3Key==None:
                s3Key='backup.tar.gz'
        else:
                s3Key+='.tar.gz'
        contents = os.listdir(directoryName)
        if s3Key==None:
                s3Key="backup."+str(time.time())+".tar.gx"
                backupFile = "/tmp/"+s3Key
        else:
                backupFile = "/tmp/backup."+str(time.time())+".tar.gx"

I do not understand how the second "if s3Key==None" could ever be true.

What version of the product are you using? On what operating system?

Just reading the code so far, planning deployment on CygWin and Linux.

Please provide any additional information below.

Original issue reported on code.google.com by holden...@gmail.com on 18 Jun 2009 at 9:20

GoogleCodeExporter commented 9 years ago
I agree.  I would suggest making a comment on the wiki page.  Perhaps the 
original
author of the page will update it.

Original comment by Mitch.Ga...@gmail.com on 21 Dec 2009 at 7:47