peterknife / boto

Automatically exported from code.google.com/p/boto
0 stars 0 forks source link

Multipart API - List Parts max_parts param is incorrect. #565

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
http://docs.amazonwebservices.com/AmazonS3/latest/API/index.html?mpUploadListPar
ts.html

The 'max-parts' request parameter is wrongly being sent using '_' instead of 
'-' in the current version 2.1.1 of boto. This means that the option gets 
ignored and 1000 parts are always returned.

Example from a captured request:
GET 
/a?uploadId=wVZWJOpwi6.FmzR9uzAq.9olRlgBhQ8IIiUU.f19t6TUQhzZCxWFJJLwYh&max_parts
=5&part-number-marker=5 HTTP/1.1

This should fix the issue.

Line 202 of multipart.py
-            query_args += '&max_parts=%d' % max_parts
+            query_args += '&max-parts=%d' % max_parts

Cheers and continue the great work!

Tom.

Original issue reported on code.google.com by tpod...@gmail.com on 30 Nov 2011 at 9:06

GoogleCodeExporter commented 9 years ago
Now being tracked in https://github.com/boto/boto/issues/416

Original comment by Mitch.Ga...@gmail.com on 30 Nov 2011 at 1:40

GoogleCodeExporter commented 9 years ago

Original comment by Mitch.Ga...@gmail.com on 30 Nov 2011 at 1:50