search

peterkovesi / PerceptualColourMaps.jl

Perceptually Uniform Colour Maps for Julia
Other
117 stars 12 forks source link

Update from REQUIRE to Project.toml #16

Closed PeterMinin closed 4 years ago

PeterMinin commented 4 years ago

Currently the last version of this package available in the General registry is 0.3.0, not the latest 0.3.1. And it looks like the project needs to have a Project.toml instead of a REQUIRE file in order to be updated. So here is a PR which does the conversion, using gen_project.jl as described in Creating Packages.

I'm not sure how to best handle the version constraints in [compat], though. The way they are now, without an upper bound, will forbid a simplified workflow for pushing future updates to the registry and generally seems to have caused some trouble in the ecosystem. But setting overly tight bounds on 0.X packages, which are the majority, is bad too. That's a hot topic, see the discussion here for example. I think the middle ground could be to go with "^2.3.0" for PyPlot, i.e. 2.3.0 <= v < 3.0.0, but only restrict the 0.X packages to "^0", i.e. all pre-1.0 versions, and be ready to handle some changes in them. Also, given all this trouble with 0.X, you might want to make a 1.0 release of this package if you don't anticipate any big changes.

peterkovesi commented 4 years ago

My apologies for not responding to your PR earlier. I have been away on holidays and have not been attending to things. Thank you very much for this work as this package has been somewhat neglected. The change from REQUIRE to Project.toml had been on my todo list for a while. Thanks again.

PeterMinin commented 4 years ago

No problem. Glad you got around to this eventually. And thanks for making the package!