codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c81526c). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   72.70%           
=========================================
  Files             ?        6           
  Lines             ?      828           
  Branches          ?        0           
=========================================
  Hits              ?      602           
  Misses            ?      226           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c81526c...fee3c6e. Read the comment docs.

peterkovesi commented 4 years ago

Sorry to be a complete noob. Does the GitHub action CI now replace Travis and appveyor? Also the ubuntu tests seem to fail with PyPlot/matplotlib issues. I presume some environment settings are needed?

timholy commented 4 years ago

No worries. Yes, you can use GitHub Actions instead (if you prefer). I went this way because it requires no other configuration for you besides the single script file. GitHub Actions is also pretty fast.

Not sure about the PyPlot, but yes, that seems to be something that ideally should be fixed. I may not make it my top priority :smile:.

peterkovesi commented 4 years ago

Thank you for your time, I will try to work out the PyPlot issues. I want to keep the plotting in the tests because some of the tests can only be judged visually, while this is not relevant for CI, I want to see them the I run the tests manually.
I will tag a release

peterkovesi / PerceptualColourMaps.jl

Set up CI using Github Actions #19

Codecov Report