search

peterldowns / pgtestdb

quickly run tests in their own temporary, isolated, postgres databases
MIT License
186 stars 14 forks source link

Use testing.TB where appropriate #3

Closed op closed 11 months ago

op commented 12 months ago

This change makes use of testing.TB to allow the New method be used in micro benchmarks too.

PS. This PR is dependent on #2 . If that change looks fine, please go ahead and merge that one first. If not, I'll update this one to reflect discussion there. :)

peterldowns commented 12 months ago

Updating New(t *testing.T, ...) -> New(t testing.TB, ...) is a great idea, but I'd like to handle the docs update differently than this. I'm going to close this PR but implement it separately and give you credit — would that be OK?

op commented 11 months ago

No worries, that works for me! :)