search

peterleinchen / harbour-defender

Defender is a privacy guard for SailfishOS
GNU General Public License v3.0
5 stars 5 forks source link

Add license, update build scripts, and add OBS support #2

Closed rinigus closed 2 years ago

rinigus commented 2 years ago

This PR adds

As you have been using SPEC directly (as far as I can tell), I have dropped YAML and cleaned up SPEC accordingly. With qmake changes, now it supports building from different directories, not just as in SDK. That was required for OBS building.

Finally, Chum section has been added.

Please review. If review is fine and merged then I can try to get it compiled for all Chum platforms and add to Chum. Current OBS build is at https://build.sailfishos.org/package/show/home:rinigus:sandbox/harbour-defender

Fixes #1

rinigus commented 2 years ago

@peterleinchen: ping. Please review. If accepted, I'll be able to proceed with submitting it to Chum.

peterleinchen commented 2 years ago

@rinigus

Sorry for delay, but as mentioned I am not able to be online that much. Will try to review/accept asap.

Sorry and thanks for your efforts Peter

On Thursday, 27 January 2022, rinigus wrote:

@peterleinchen: ping. Please review. If accepted, I'll be able to proceed with submitting it to Chum.

-- Reply to this email directly or view it on GitHub: https://github.com/peterleinchen/harbour-defender/pull/2#issuecomment-1023578092 You are receiving this because you were mentioned.

Message ID: @.***

-- Peter Leinchen

Sent from my mobile device

rinigus commented 2 years ago

@peterleinchen: thank you very much for looking into it. Just wanted to be sure that it will not stay forgotten :).

Looking forward for your review.

rinigus commented 2 years ago

Ping! Any progress with it?

peterleinchen commented 2 years ago

Pong.

I am sorry, but I did (almost) not touch any computer the last weeks.

I do know and remember, seeing the mail open in my mailbox. And will try to do so asap, but no promise.

Please feel free to poing me once more.

Best Peter

On Sunday, 6 February 2022, rinigus wrote:

Ping! Any progress with it?

-- Reply to this email directly or view it on GitHub: https://github.com/peterleinchen/harbour-defender/pull/2#issuecomment-1030777499 You are receiving this because you were mentioned.

Message ID: @.***

-- Peter Leinchen

Sent from my mobile device

rinigus commented 2 years ago

Hi! This is a reminder - hopefully you can take a look into these changes soon.

rinigus commented 2 years ago

Hi! Any hope to get that reviewed? :)

peterleinchen commented 2 years ago

I do hope so ;)

At home again and looking to that this week (hooefully :)

Best

On Sunday, 20 February 2022, rinigus wrote:

Hi! Any hope to get that reviewed? :)

-- Reply to this email directly or view it on GitHub: https://github.com/peterleinchen/harbour-defender/pull/2#issuecomment-1046249904 You are receiving this because you were mentioned.

Message ID: @.***

-- Peter Leinchen

Sent from my mobile device

rinigus commented 2 years ago

Ping, please review

rinigus commented 2 years ago

@peterleinchen, please review this PR

peterleinchen commented 2 years ago

Rinigus,

very very sorry for looong delay! I did review but and can only tell about stuff I know (or think I know) ;) and this lokks fine regarding yaml and changes cannot say about chum additions and the pro file changes.

But I think this is fine. I merged it (now :)

Thank you Peter

rinigus commented 2 years ago

Great! I will proceed then with pushing it to Chum. Will test how it goes there and then probably would ask you to make new release for cleaner builds. Such tag is not needed yet, let me test it first :)

peterleinchen commented 2 years ago

Sure :)

On Saturday, 12 March 2022, rinigus wrote:

Great! I will proceed then with pushing it to Chum. Will test how it goes there and then probably would ask you to make new release for cleaner builds. Such tag is not needed yet, let me test it first :)

-- Reply to this email directly or view it on GitHub: https://github.com/peterleinchen/harbour-defender/pull/2#issuecomment-1065892196 You are receiving this because you modified the open/close state.

Message ID: @.***

-- Peter Leinchen

Sent from my mobile device

rinigus commented 2 years ago

All looks to be fine, as far as I can see. Would you mind to tag a new release and then I can push it to Chum proper. Current Chum testing builds are at https://build.sailfishos.org/package/show/sailfishos:chum:testing/harbour-defender and, as you can see, have a rather long version :) . That would be fixed as soon as you tag and I restart rebuilds.

peterleinchen commented 2 years ago

Wow. A "bit" faster than me :D

I changed version in spec to 0.6.0 and set new tag 0.6.0. Let's try...

P.S.: Do I need (should have) an account on OBS? Sign up is disabled.

On Sunday, 13 March 2022, rinigus wrote:

All looks to be fine, as far as I can see. Would you mind to tag a new release and then I can push it to Chum proper. Current Chum testing builds are at https://build.sailfishos.org/package/show/sailfishos:chum:testing/harbour-defender and, as you can see, have a rather long version :) . That would be fixed as soon as you tag and I restart rebuilds.

-- Reply to this email directly or view it on GitHub: https://github.com/peterleinchen/harbour-defender/pull/2#issuecomment-1066046939 You are receiving this because you modified the open/close state.

Message ID: @.***

-- Peter Leinchen

Sent from my mobile device

rinigus commented 2 years ago

@peterleinchen: yes, you need to get an account at OBS. For that, ping "lbt" and "Keto" and ask for account on IRC #sailfishos channel.

When you get used to OBS, it is very simple and convenient.

I have updated the build and will push it now to Chum main repository. Thanks for tagging!