search

petermichaux / maria

The MVC framework for JavaScript applications. The real MVC. The Smalltalk MVC. The Gang of Four MVC.
BSD 2-Clause "Simplified" License
764 stars 51 forks source link

Issue #26 - added new pages and css #45

Closed laantorchaweb closed 11 years ago

laantorchaweb commented 11 years ago

I changed the structure for the Maria page, added css styles according to the new designs. I also added sintax highlither functionality for the quick intro page.

petermichaux commented 11 years ago

Thank you very much.

I've merged locally and will make a few implementation changes, for example, switching to Google font hosting. After those changes are made, I'll push to github and deploy the site.

petermichaux commented 11 years ago

highlight.js is erroring because addEventListener does not exist in IE6/7/8. Is there a version of highlight.js that is cross browser?

laantorchaweb commented 11 years ago

It seems that the last version of the sintax highlighter dropped support for these browsers in order to reduce filesize and be more performant. I think that with only the css looks fine in these browsers, so i put some conditional logic to load the script. What do you think?

petermichaux commented 11 years ago

The conditional comment solution is ok with me. I tried to merge but my local repository has moved along far enough that git didn't seem to know how to do the merge. I've merged the changes manually.

Thanks.

petermichaux commented 11 years ago

Oops. The conditional comments don't work. That comments the syntax highlighting out in all browsers except IE9 and IE10.

petermichaux commented 11 years ago

I'll feature test for typeof window.addEventListener === 'function'.

petermichaux commented 11 years ago

I've pushed my local changes to Github. I've tried to simplify the implementation without changing the appearance (with the exception of a bit of reducing some vertical whitespace.) It looks really good. I appreciate your help.

There is still more work to be done before this can be deployed. There is still some "lorem ipsum" text that I need to work on.