petermonky / pe

0 stars 0 forks source link

Last contact date can be before birth date #10

Open petermonky opened 2 years ago

petermonky commented 2 years ago

image.png

The last contact date of a client can be before their birth date. Though a rare scenario, this could, in the long run, confuse users who mistakenly type the wrong birth date or last contact date.

Expected: The application rejects clients whose last contact date is before their birth date

Actual: The application accepts clients regardless of difference between last contact date and birth date

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Birthdays can be edited to after last contacted date

image.png

I added a new contact, and changed the date of birth to after the last contacted date. This should not be allowed as you can't physically meet a contact before the date of birth


[original: nus-cs2103-AY2122S2/pe-interim#2940] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Unrealistic situation that users won't face, and if they do edit the birthday to after last contacted date, it would be an intentional behaviour that has special meaning for the user

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]