petermonky / pe

0 stars 0 forks source link

Cannot find client from list of clients #3

Open petermonky opened 2 years ago

petermonky commented 2 years ago

image.png

A client as stored in the application cannot be found unless the user runs clients first, which is confusing, as this is not explicitly stated in the User Guide. The error message is also somewhat inaccurate.

Expected:: Client with vijay in name is found

Actual: No clients are found

nus-pe-bot commented 2 years ago

Team's Response

image.png

No steps were provided to reproduce this bug, so we did our best by inferring from the screenshot provided by the reporter. We were not able to reproduce the bug, as seen in the screenshot above.

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: Apologies, the steps to reproduce this issue is as follows:

  1. add a client using addClient
  2. alter the filtered client list via findClient or filterClient such that the added client is not visible
  3. find the client using findClient

If the filtered client list is not reset before step 3 using clients, findClient will not be able to find the added client. Users would tediously have to call clients every time to correctly perform findClient; the somewhat inaccurate error message of "There are no clients in your contact list to find" also does not help as the client is technically in the contact list, but is simply not visible as they have been filtered out. However, reviewing it now, a more appropriate severity would be severity.Low as it is expected to pose only a minor inconcenience.