search

petermonky / pe

0 stars 0 forks source link

Names of clients are case-sensitive #4

Open petermonky opened 2 years ago

petermonky commented 2 years ago

image.png

The two clients as input above are likely to be the same person. The application, however, does not detect this and effectively allows for duplicate persons.

Expected: Clients with the same name (case-insensitive) are detected as duplicates

Actual: Clients with the same name (case-insensitive) are not detected as duplicates and accepted by the application

nus-pe-script commented 2 years ago

Team's Response

We have already accepted another bug regarding this exact issue of our client list not detecting clients with the same name in a case-sensitive fashion

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate client entries might go unnoticed

Problem: User is able to add two similar client data entries with the same name (with one being lower case and the other being proper upper case) and same data, as shown in the picture below

image.png

Steps to reproduce:

Execute the command

addClient n/John Doe p/98765432 e/johnd@example.com a/311 Clementi Ave 2 #02-25 b/21-03-1999 lc/21-03-2022 21:03

and

addClient n/john doe p/98765432 e/johnd@example.com a/311 Clementi Ave 2 #02-25 b/21-03-1999 lc/21-03-2022 21:03

Expected:

The application gives some warning about possible duplication.

Actual:

The client is successfully added.

This might cause inconvenience as the client list gets longer and user is not aware of such duplication, since the two upper case and lower case names are likely to refer to the same person.

[original: nus-cs2103-AY2122S2/pe-interim#732] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree and accept this bug, this was an oversight on our part.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]